Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navbar style for pkgdown 2.1.0 #50

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Update navbar style for pkgdown 2.1.0 #50

merged 1 commit into from
Jul 24, 2024

Conversation

nanxstats
Copy link
Collaborator

This PR updates the navbar link style in extra.css to accommodate the HTML class name changes in pkgdown 2.1.0 (due to the new option to have light/dark themes).

This would restore the navbar look and feel under pkgdown < 2.1.0. Without this change, when rendering with pkgdown 2.1.0, the navbar link hover and active state color contrast will be too low.

@nanxstats nanxstats added the documentation Improvements or additions to documentation label Jul 24, 2024
@nanxstats nanxstats requested a review from elong0527 July 24, 2024 04:17
@nanxstats nanxstats merged commit 118d159 into master Jul 24, 2024
7 checks passed
@nanxstats nanxstats deleted the navbar branch July 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants